Skip to content

Map SLOT_NAME_DPI_BUTTON to DpiToggle and add verification tests - #703

Merged
AprilNEA merged 4 commits into
AprilNEA:masterfrom
ediaz2:master
Aug 27, 2026
Merged

Map SLOT_NAME_DPI_BUTTON to DpiToggle and add verification tests#703
AprilNEA merged 4 commits into
AprilNEA:masterfrom
ediaz2:master

Conversation

@ediaz2

@ediaz2 ediaz2 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

The MX Vertical's top button is missing from the UI because Logitech names the slot SLOT_NAME_DPI_BUTTON instead of the usual SLOT_NAME_MODESHIFT_BUTTON. Both refer to the same control, so we add pattern matching to recognize both.

Changes

  • geometry.rs: map SLOT_NAME_DPI_BUTTON to ButtonId::DpiToggle alongside SLOT_NAME_MODESHIFT_BUTTON
  • Add unit test verifying both slot names map correctly

Testing

  • cargo fmt --all -- --check — clean
  • cargo clippy --workspace --all-targets -- -D warnings — clean
  • cargo test --workspace — clean, including new test for DPI button slot names

Fixes #103
Screenshot 2026-08-20 at 00-35-57

@ediaz2
ediaz2 requested a review from AprilNEA as a code owner August 20, 2026 05:36
@greptile-apps

greptile-apps Bot commented Aug 20, 2026

Copy link
Copy Markdown

Greptile Summary

This PR recognizes Logitech’s alternate DPI button slot name so the MX Vertical’s top button appears as the existing DPI toggle control.

  • Maps both SLOT_NAME_MODESHIFT_BUTTON and SLOT_NAME_DPI_BUTTON to ButtonId::DpiToggle.
  • Adds unit coverage for both slot-name variants.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
crates/openlogi-desktop/src/features/mouse/geometry.rs Adds a focused slot-name alias mapping and verifies both names resolve to the same DPI toggle control.

Reviews (4): Last reviewed commit: "Merge branch 'master' into master" | Re-trigger Greptile

@davidbudnick davidbudnick added the type: feature New feature request label Aug 20, 2026
@mallewski

Copy link
Copy Markdown

Hi @AprilNEA, I really enjoy your app - and even more so now that I’ve found a workaround to get the Top Button working on my MX Vertical! I truly appreciate your hard work on this project. Since the Logitech MX Vertical is one of the most widely used ergonomic mice on the market, I wanted to gently bump this PR to see if it could get a bit more visibility. No rush at all, I just thought natively integrating this fix would be a huge quality-of-life improvement for many users

@AprilNEA AprilNEA added type: bug Something is broken or behaves incorrectly and removed type: feature New feature request labels Aug 27, 2026
@AprilNEA

Copy link
Copy Markdown
Owner

Hi @AprilNEA, I really enjoy your app - and even more so now that I’ve found a workaround to get the Top Button working on my MX Vertical! I truly appreciate your hard work on this project. Since the Logitech MX Vertical is one of the most widely used ergonomic mice on the market, I wanted to gently bump this PR to see if it could get a bit more visibility. No rush at all, I just thought natively integrating this fix would be a huge quality-of-life improvement for many users

Thanks for the kind words and for confirming the workaround!

@AprilNEA
AprilNEA merged commit c11aa07 into AprilNEA:master Aug 27, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something is broken or behaves incorrectly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing top button on MX Vertical

4 participants