Map SLOT_NAME_DPI_BUTTON to DpiToggle and add verification tests - #703
Conversation
Greptile SummaryThis PR recognizes Logitech’s alternate DPI button slot name so the MX Vertical’s top button appears as the existing DPI toggle control.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| crates/openlogi-desktop/src/features/mouse/geometry.rs | Adds a focused slot-name alias mapping and verifies both names resolve to the same DPI toggle control. |
Reviews (4): Last reviewed commit: "Merge branch 'master' into master" | Re-trigger Greptile
|
Hi @AprilNEA, I really enjoy your app - and even more so now that I’ve found a workaround to get the Top Button working on my MX Vertical! I truly appreciate your hard work on this project. Since the Logitech MX Vertical is one of the most widely used ergonomic mice on the market, I wanted to gently bump this PR to see if it could get a bit more visibility. No rush at all, I just thought natively integrating this fix would be a huge quality-of-life improvement for many users |
Thanks for the kind words and for confirming the workaround! |
Summary
The MX Vertical's top button is missing from the UI because Logitech names the slot
SLOT_NAME_DPI_BUTTONinstead of the usualSLOT_NAME_MODESHIFT_BUTTON. Both refer to the same control, so we add pattern matching to recognize both.Changes
geometry.rs: mapSLOT_NAME_DPI_BUTTONtoButtonId::DpiTogglealongsideSLOT_NAME_MODESHIFT_BUTTONTesting
cargo fmt --all -- --check— cleancargo clippy --workspace --all-targets -- -D warnings— cleancargo test --workspace— clean, including new test for DPI button slot namesFixes #103
